Messages in this thread | | | Subject | Re: [PATCH] clocksource/drivers/pistachio: Fix wrong calculated clocksource read value | From | Daniel Lezcano <> | Date | Wed, 16 Dec 2015 10:21:55 +0100 |
| |
On 12/16/2015 08:36 AM, Jisheng Zhang wrote: > On Wed, 16 Dec 2015 15:28:07 +0800 wrote: > >> On Wed, 16 Dec 2015 15:11:25 +0800 >> Jisheng Zhang wrote: >> >>> Dear Daniel, >>> >>> On Tue, 15 Dec 2015 21:59:30 +0100 Daniel Lezcano wrote: >>> >>>> On 11/25/2015 04:42 PM, Jisheng Zhang wrote: >>>>> Let's assume the counter value is 0xf000000, the pistachio clocksource >> >> oops, sorry, should be 0xf0000000. Do I need to send a v2 patch? > > And in fact, clocksource_mmio_readw_down() also has similar issue, but it masks > with c->mask before return, the c->mask is less than 32 bit (because the > clocksource_mmio_init think number of valid bits > 32 or < 16 is invalid.) > the higher 32 bits are masked off, so we never saw such issue. But we'd better > to fix that, what's your opinion?
I think we should have a look to this portion closely.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |