Messages in this thread | | | From | Chao Yu <> | Subject | RE: [PATCH 7/8] f2fs: introduce new option for controlling data flush | Date | Wed, 16 Dec 2015 11:19:06 +0800 |
| |
Hi Jaegeuk,
> -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Wednesday, December 16, 2015 10:49 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 7/8] f2fs: introduce new option for controlling data flush > > Hi Chao, > > On Wed, Dec 16, 2015 at 10:38:27AM +0800, Chao Yu wrote: > > ... > > > > > +++ b/fs/f2fs/super.c > > > > @@ -67,6 +67,7 @@ enum { > > > > Opt_extent_cache, > > > > Opt_noextent_cache, > > > > Opt_noinline_data, > > > > + Opt_data_flush, > > > > > > Need Opt_nodata_flush too. > > > > We need this unless we set data_flush as a default option. Is that right? > > I meant both of them.
Yeah, I know that. But the point I meant was: Normally we can detect user's mount option by test_opt(DATA_FLUSH), but if data_flush option was set as a default option in f2fs, we need to introduce nodata_flush to indicate whether user want to disable it or not, because we can't disable data_flush option by mount without it since f2fs will set data_flush by itself.
So it seems nodata_flush is redundant unless data_flush is set by default.
How do you think of it?
Thanks,
> > Thanks, > > > > > Thanks, > > > > > > > > Thanks, > > > > > > > Opt_nodiscard, > > > > Opt_err, > > > > }; > > > > @@ -92,6 +93,7 @@ static match_table_t f2fs_tokens = { > > > > {Opt_extent_cache, "extent_cache"}, > > > > {Opt_noextent_cache, "noextent_cache"}, > > > > {Opt_noinline_data, "noinline_data"}, > > > > + {Opt_data_flush, "data_flush"}, > > > > {Opt_nodiscard, "nodiscard"}, > > > > {Opt_err, NULL}, > > > > }; > > > > @@ -411,6 +413,9 @@ static int parse_options(struct super_block *sb, char *options) > > > > case Opt_noinline_data: > > > > clear_opt(sbi, INLINE_DATA); > > > > break; > > > > + case Opt_data_flush: > > > > + clear_opt(sbi, DATA_FLUSH); > > > > + break; > > > > default: > > > > f2fs_msg(sb, KERN_ERR, > > > > "Unrecognized mount option \"%s\" or missing value", > > > > @@ -694,6 +699,8 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root) > > > > seq_puts(seq, ",extent_cache"); > > > > else > > > > seq_puts(seq, ",noextent_cache"); > > > > + if (test_opt(sbi, DATA_FLUSH)) > > > > + seq_puts(seq, ",data_flush"); > > > > seq_printf(seq, ",active_logs=%u", sbi->active_logs); > > > > > > > > return 0; > > > > -- > > > > 2.6.3 > > > >
| |