lkml.org 
[lkml]   [2015]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: staging: lustre: Delete unnecessary goto statements in six functions
    From
    Date

    > rc = mdc_queue_wait(req);
    > goto out;
    > out:
    > ptlrpc_req_finished(req);
    > return rc;
    > }
    > ---------------------
    >
    > I think if the last goto out; is to be removed,
    > then it should be replaced by a blank line.
    >
    > It separates the last operation block from the return.

    Would you like to point a very specific coding style issue out?
    How often should jump labels preceded with blank lines?

    Regards,
    Markus


    \
     
     \ /
      Last update: 2015-12-15 19:41    [W:2.603 / U:0.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site