Messages in this thread | | | Subject | Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions | From | Joe Perches <> | Date | Tue, 15 Dec 2015 06:27:56 -0800 |
| |
On Sun, 2015-12-13 at 14:52 +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 13 Dec 2015 09:30:47 +0100 > > Six goto statements referred to a source code position directly behind them. > Thus omit such unnecessary jumps.
I suggest you leave a blank line instead of deleting the goto.
> diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c [] > @@ -554,7 +554,6 @@ static struct dentry *ll_lookup_it(struct inode *parent, struct dentry *dentry, > retval = NULL; > else > retval = dentry; > - goto out; > out: > if (req) > ptlrpc_req_finished(req);
etc.,,
| |