Messages in this thread | | | Subject | Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement | From | Pan Xinhui <> | Date | Tue, 15 Dec 2015 13:43:07 +0800 |
| |
Hi, Greg This patch is dropped, I have created another patch based on Jiri' patch. On 2015/12/15 02:55, Greg Kroah-Hartman wrote: > On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote: >> From: xinhui <xinhui@linux.vnet.ibm.com> >> >> If gsm driver fails to activate one mux, and this mux is not stored in >> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this >> is a legal case. So just do a simple check instead of WARN_ON. >> >> There is one filed gsm->num to store its index of gsm_mux[]. So use >> gsm->num to remove itself from gsm_mux[] instead of the for-loop >> traverse. >> >> Reported-by: Dmitry Vyukov <dvyukov@google.com> >> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open") >> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> > > the signed-off-by name has to match your from: name :( >
| |