lkml.org 
[lkml]   [2015]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RESEND 22/27] tools/hv: Use include/uapi with __EXPORTED_HEADERS__
    On Mon, Dec 14, 2015 at 04:01:53PM -0800, K. Y. Srinivasan wrote:
    > From: Kamal Mostafa <kamal@canonical.com>
    >
    > Use the local uapi headers to keep in sync with "recently" added #define's
    > (e.g. VSS_OP_REGISTER1).
    >
    > Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb

    Please use the "correct" way of listing this:
    3eb2094c59e8 ("Adding makefile for tools/hv")

    And as this is an old kernel, shouldn't it go into stable releases? Or
    does that mean that no one really ever runs into this issue?

    > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    > ---
    > tools/hv/Makefile | 2 ++
    > 1 files changed, 2 insertions(+), 0 deletions(-)
    >
    > diff --git a/tools/hv/Makefile b/tools/hv/Makefile
    > index a8ab795..a8c4644 100644
    > --- a/tools/hv/Makefile
    > +++ b/tools/hv/Makefile
    > @@ -5,6 +5,8 @@ PTHREAD_LIBS = -lpthread
    > WARNINGS = -Wall -Wextra
    > CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS) $(shell getconf LFS_CFLAGS)
    >
    > +CFLAGS += -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include

    Why do you need ../../include also?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2015-12-15 04:41    [W:4.335 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site