Messages in this thread | | | Date | Mon, 14 Dec 2015 14:19:19 +0900 | From | Simon Horman <> | Subject | Re: [PATCH 05/10] drivers/pci: make host/pci-rcar-gen2.c explicitly non-modular |
| |
On Sat, Dec 12, 2015 at 08:41:52PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pci/host/Kconfig:config PCI_RCAR_GEN2 > drivers/pci/host/Kconfig: bool "Renesas R-Car Gen2 Internal PCI controller" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We don't have to disallow a driver unbind, since that is already > done for us in this driver. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We don't replace module.h with init.h since the file already has that. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Simon Horman <horms@verge.net.au> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
| |