Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH RESEND] misc/bmp085: Enable building as a module | Date | Mon, 14 Dec 2015 23:23:45 +0100 |
| |
On Monday 14 December 2015 14:29:23 Ben Hutchings wrote: > Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085 > driver' changed the BMP085 config symbol to a boolean. I see no > reason why the shared code cannot be built as a module, so change it > back to tristate. > > Fixes: 985087dbcb02 ("misc: add support for bmp18x chips to the bmp085 driver") > Cc: Eric Andersson <eric.andersson@unixphere.com> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> >
Looks good to me. There are often subtle bugs in configurations like these where a driver can depend on either SPI or I2C, but I don't see a problem here, because the common code still only gets built as a module if neither front-end is built-in.
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |