Messages in this thread | | | From | bsegall@google ... | Subject | Re: [PATCH] sched/fair: fix mul overflow on 32-bit systems | Date | Mon, 14 Dec 2015 09:51:58 -0800 |
| |
Morten Rasmussen <morten.rasmussen@arm.com> writes:
> On Fri, Dec 11, 2015 at 11:18:56AM -0800, bsegall@google.com wrote: >> So uh yeah, my initial impression is "rip it out", but if being >> immediately-correct is important in the case of one task being most of >> the utilization, rather than when it is more evenly distributed, it >> would probably make more sense to instead put in the add-on-enqueue >> code. > > I would prefer if stayed in. There are several patch sets posted for > review that use util_avg.
Yeah, I missed the attach call on enqueue, which means my argument is basically invalid, as the code is sensible enough at the moment ("rip it out" was meant to refer only to the remove-on-migrate, not the whole util_avg).
| |