Messages in this thread | | | Subject | Re: [PATCH 1/2] zram: Less checks in zram_bvec_write() after error detection | From | SF Markus Elfring <> | Date | Mon, 14 Dec 2015 15:03:49 +0100 |
| |
>> I suggest to make the affected exception handling a bit more efficient. >> Such source code fine-tuning has got a few special consequences. > > by 'more efficient' you mean saving cpu cycles on 'bvec->bv_len != PAGE_SIZE' > comparison in exception/error path?
Yes …
> ... > check_strm: > if (zstrm) > zcomp_strm_release(zram->comp, zstrm); > if (is_partial_io(bvec)) { > free_uncmem: > kfree(uncmem); > } > ...
I propose to jump over two sanity checks.
> no.
Thanks for your feedback.
Regards, Markus
| |