lkml.org 
[lkml]   [2015]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] zram: Less checks in zram_bvec_write() after error detection
    From
    Date
    >> I suggest to make the affected exception handling a bit more efficient.
    >> Such source code fine-tuning has got a few special consequences.
    >
    > by 'more efficient' you mean saving cpu cycles on 'bvec->bv_len != PAGE_SIZE'
    > comparison in exception/error path?

    Yes …


    > ...
    > check_strm:
    > if (zstrm)
    > zcomp_strm_release(zram->comp, zstrm);
    > if (is_partial_io(bvec)) {
    > free_uncmem:
    > kfree(uncmem);
    > }
    > ...

    I propose to jump over two sanity checks.


    > no.

    Thanks for your feedback.

    Regards,
    Markus


    \
     
     \ /
      Last update: 2015-12-14 15:21    [W:4.033 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site