Messages in this thread | | | Date | Mon, 14 Dec 2015 19:31:42 +0900 | Subject | Re: [PATCH] extcon: max14577: fix handling return value of regmap_irq_get_virq | From | Krzysztof Kozlowski <> |
| |
2015-12-14 19:06 GMT+09:00 Andrzej Hajda <a.hajda@samsung.com>: > The function can return negative values, so its result should > be assigned to signed variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > drivers/extcon/extcon-max14577.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Do you plan to fix also max77693?
Best regards, Krzysztof
| |