lkml.org 
[lkml]   [2015]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 12/38] HSI: omap_ssi_port: fix handling of_get_named_gpio result
From
Date
Hi,

Ping - almost three months passed.

Regards
Andrzej


On 09/21/2015 03:33 PM, Andrzej Hajda wrote:
> The function can return negative value.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/hsi/controllers/omap_ssi_port.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
> index 1f8652b..d93dd09 100644
> --- a/drivers/hsi/controllers/omap_ssi_port.c
> +++ b/drivers/hsi/controllers/omap_ssi_port.c
> @@ -1147,13 +1147,13 @@ static int __init ssi_port_probe(struct platform_device *pd)
> goto error;
> }
>
> - cawake_gpio = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0);
> - if (cawake_gpio < 0) {
> + err = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0);
> + if (err < 0) {
> dev_err(&pd->dev, "DT data is missing cawake gpio (err=%d)\n",
> - cawake_gpio);
> - err = -ENODEV;
> + err);
> goto error;
> }
> + cawake_gpio = err;
>
> err = devm_gpio_request_one(&port->device, cawake_gpio, GPIOF_DIR_IN,
> "cawake");



\
 
 \ /
  Last update: 2015-12-14 12:01    [W:0.039 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site