Messages in this thread | | | Date | Mon, 14 Dec 2015 19:03:23 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH 1/2] zram: Less checks in zram_bvec_write() after error detection |
| |
On (12/14/15 07:58), SF Markus Elfring wrote: [..] > > keep it the way it is please. > > I suggest to make the affected exception handling a bit more efficient. > Such source code fine-tuning has got a few special consequences.
by 'more efficient' you mean saving cpu cycles on 'bvec->bv_len != PAGE_SIZE' comparison in exception/error path?
... check_strm: if (zstrm) zcomp_strm_release(zram->comp, zstrm); if (is_partial_io(bvec)) { free_uncmem: kfree(uncmem); } ...
no.
-ss
| |