Messages in this thread | | | Date | Mon, 14 Dec 2015 12:31:22 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls |
| |
On Mon, Dec 14, 2015 at 10:08:03AM +0100, SF Markus Elfring wrote: > > Markus, please stop sending these things to rename out labels unless > > there is a bug. CodingStyle allows out labels. > > How does this feedback fit to information like the following? > > "… > Chapter 7: … > … > Choose label names which say what the goto does or why the goto exists.
A lot of people think "out" says what the goto does and why it exists. I personally don't agree with them but if you look at when I complain about it, it's almost always when it causes a bug.
> … Avoid using GW-BASIC names …
Those when people just use numbers for their label names instead of words like out1, out2, out4, out5. It's a different thing.
regards, dan carpenter
| |