Messages in this thread | | | Date | Sun, 13 Dec 2015 13:35:09 -0300 | Subject | Re: [PATCH v2 01/10] usb: host: ehci-sched: refactor scan_isoc function | From | "Geyslan G. Bem" <> |
| |
2015-12-13 12:29 GMT-03:00 Alan Stern <stern@rowland.harvard.edu>: > On Sun, 13 Dec 2015, Geyslan G. Bem wrote: > >> This patch removes an infinite 'for' loop and makes use of the already >> existing 'restart' tag instead, reducing one leading tab. >> >> It also puts the easier evaluation (live variable) to be the first in >> two conditionals. >> >> if (live && frame == now_frame) { ... >> >> if (live && ((frame == now_frame) || ... > > You should never do this. The first test in a conditional should be > the one that is most likely to cause the expression to fail. In this > case, live is almost always true whereas frame == now_frame is true > only some percentage of the time. Therefore the frame == now_frame > test should come first. I see. Doing v3 and undoing the reordering.
> > Alan Stern >
-- Regards,
Geyslan G. Bem hackingbits.com
| |