Messages in this thread |  | | Date | Mon, 14 Dec 2015 00:17:04 +0100 | | From | Jiri Olsa <> | | Subject | Re: [PATCH/RFC 08/16] perf tools: Export a couple of hist functions |
| |
On Thu, Dec 10, 2015 at 04:53:27PM +0900, Namhyung Kim wrote: > These are necessary for multi threaded sample processing: > > - hists__get__get_rotate_entries_in() > - hists__collapse_insert_entry() > - __hists__init() > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/util/hist.c | 19 ++++++++++++------- > tools/perf/util/hist.h | 5 +++++ > 2 files changed, 17 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index d534ed76164b..ea4f3ad978b0 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -972,9 +972,8 @@ void hist_entry__delete(struct hist_entry *he) > * collapse the histogram > */ > > -static bool hists__collapse_insert_entry(struct hists *hists __maybe_unused, > - struct rb_root *root, > - struct hist_entry *he) > +bool hists__collapse_insert_entry(struct hists *hists __maybe_unused, > + struct rb_root *root, struct hist_entry *he) > { > struct rb_node **p = &root->rb_node; > struct rb_node *parent = NULL; > @@ -1014,7 +1013,7 @@ static bool hists__collapse_insert_entry(struct hists *hists __maybe_unused, > return true; > } > > -static struct rb_root *hists__get_rotate_entries_in(struct hists *hists) > +struct rb_root *hists__get_rotate_entries_in(struct hists *hists) > { > struct rb_root *root; > > @@ -1549,10 +1548,8 @@ int perf_hist_config(const char *var, const char *value) > return 0; > } > > -static int hists_evsel__init(struct perf_evsel *evsel) > +int __hists__init(struct hists *hists)
and this one also ;-)
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
|  |