lkml.org 
[lkml]   [2015]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double allocations
On Sat, Dec 12, 2015 at 04:18:26AM +0000, Ben Hutchings wrote:
> On Wed, 2015-12-09 at 09:36 +0000, Luis Henriques wrote:
> > 3.16.7-ckt21 -stable review patch.  If anyone has any objections,
> > please let me know.
> >
> > ------------------
> >
> > From: Eric Dumazet <edumazet@google.com>
> >
> > commit 4ece9009774596ee3df0acba65a324b7ea79387c upstream.
> >
> > sit0 device allocates its percpu storage twice :
> > - One time in ipip6_tunnel_init()
> > - One time in ipip6_fb_tunnel_init()
> >
> > Thus we leak 48 bytes per possible cpu per network namespace
> > dismantle.
> >
> > ipip6_fb_tunnel_init() can be much simpler and does not
> > return an error, and should be called after register_netdev()
> [...]
>
> Doesn't this introduce a race condition when sit is a module?  There
> seems to be nothing to prevent access to the partially initialised
> device after calling register_netdev(), if sit_init_net() is called
> during module loading rather than during namespace creation.
>

This seems to be an upstream issue, not specific to the 3.16.y-ckt
stable kernel. If that is the case, I guess I'll just keep this patch
and later apply the fix. Or do you think this race is really likely
to be a worst problem than then issue the patch is trying to fix?

Cheers,
--
Luís

> Ben.
>
> --
> Ben Hutchings
> Knowledge is power. France is bacon.



\
 
 \ /
  Last update: 2015-12-13 20:21    [W:0.300 / U:8.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site