Messages in this thread Patch in this message | | | Subject | [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params() | From | SF Markus Elfring <> | Date | Sat, 12 Dec 2015 15:41:41 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 12 Dec 2015 13:44:06 +0100
The variable "pl" was declared and immediately assigned a return value from a function call in a separate statement.
* Let us express the desired variable initialisation directly.
* Avoid the repetition of the data type specification for the involved memory allocation according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/target/iscsi/iscsi_target_parameters.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c index e0b173d..3f3842f 100644 --- a/drivers/target/iscsi/iscsi_target_parameters.c +++ b/drivers/target/iscsi/iscsi_target_parameters.c @@ -200,9 +200,8 @@ free_param: int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr) { struct iscsi_param *param; - struct iscsi_param_list *pl; + struct iscsi_param_list *pl = kzalloc(sizeof(*pl), GFP_KERNEL); - pl = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL); if (!pl) { pr_err("Unable to allocate memory for" " struct iscsi_param_list.\n"); -- 2.6.3
| |