Messages in this thread | | | Date | Sun, 13 Dec 2015 02:01:22 +0200 | Subject | Re: [PATCH v2] vhost: replace % with & on data path | From | Andy Shevchenko <> |
| |
On Fri, Dec 4, 2015 at 10:19 PM, Venkatesh Srinivas <venkateshs@google.com> wrote: > On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote: >> We know vring num is a power of 2, so use & >> to mask the high bits. >> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> >> --- > > The generated code switches from DIV -> masking, source is clearer as well.
First impression was why, now it seems that compiler can't predict this for variables. For constants it would be optimized to the same, I suppose.
> > Tested-by: Venkatesh Srinivas <venkateshs@google.com> > > -- vs; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- With Best Regards, Andy Shevchenko
| |