lkml.org 
[lkml]   [2015]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2 18/61] net: switchdev: fix return code of fdb_dump stub
    Date
    4.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dragos Tatulea <dragos@endocode.com>

    [ Upstream commit 24cb7055a3066634a0f3fa0cd6a4780652905d35 ]

    rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op,
    but when CONFIG_NET_SWITCHDEV is off, it returns an error.

    Fix that by returning the given unmodified idx.

    A similar fix was 0890cf6cb6ab ("switchdev: fix return value of
    switchdev_port_fdb_dump in case of error") but for the CONFIG_NET_SWITCHDEV=y
    case.

    Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
    Signed-off-by: Dragos Tatulea <dragos@endocode.com>
    Acked-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/net/switchdev.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/net/switchdev.h
    +++ b/include/net/switchdev.h
    @@ -268,7 +268,7 @@ static inline int switchdev_port_fdb_dum
    struct net_device *filter_dev,
    int idx)
    {
    - return -EOPNOTSUPP;
    + return idx;
    }

    #endif



    \
     
     \ /
      Last update: 2015-12-12 22:21    [W:4.066 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site