lkml.org 
[lkml]   [2015]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code
From
Date
On Fri, 2015-12-11 at 11:23 +0800, Herbert Xu wrote:
> On Thu, Dec 10, 2015 at 08:39:45AM -0800, Tim Chen wrote:
> >
> > The inner cipher is called synchronously from the outer layer
> > async cipher algorithm in cbc_mb_async_ablk_decrypt via
> >
> > err = crypto_blkcipher_crt(child_tfm)->decrypt(
> > &rctx->desc, req->dst, req->src, req->nbytes);
>
> We should avoid bypassing the API and directly calling crypto
> driver functions like this.
>
> What if you made it a proper ablkcipher and just called it through
> the API?
>
> Thanks,

Direct call I assume have less overhead. Let me think about
making the inner cipher ablkcipher. I may need to rewrite a lot
of the glue layer :(

Tim



\
 
 \ /
  Last update: 2015-12-11 18:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog