lkml.org 
[lkml]   [2015]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/4] usb: serial: remove redundant conditions
From
2015-12-11 6:16 GMT-03:00 Johan Hovold <johan@kernel.org>:
> On Thu, Dec 10, 2015 at 05:50:09PM -0300, Geyslan G. Bem wrote:
>> This patch removes redundant conditions.
>>
>> (!A || (A && B)) is the same as (!A || B).
>> (length && length > 5) can be reduced to a single evaluation.
>>
>> Tested by compilation only.
>> Caught by cppcheck.
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++---------------------
>> drivers/usb/serial/mos7840.c | 2 +-
>> 2 files changed, 15 insertions(+), 22 deletions(-)
>
> Please split this up per driver as I (and Felipe) asked.
Sorry. get_maintainer give same maintainers, but the question here is
the different drivers. Ok, I'll send them splitted.

>
> You can send these two separate from the rest, and remember to CC
> the USB list.
Ok, tks.

>
> Thanks,
> Johan



--
Regards,

Geyslan G. Bem
hackingbits.com


\
 
 \ /
  Last update: 2015-12-11 11:01    [W:0.067 / U:2.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site