lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kexec: use list_for_each_entry_safe in kimage_free_page_list
On 12/09/15 at 12:08am, Geliang Tang wrote:
> Use list_for_each_entry_safe() instead of list_for_each_safe() to
> simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> kernel/kexec_core.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 11b64a6..f3951c7 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -310,12 +310,9 @@ static void kimage_free_pages(struct page *page)
>
> void kimage_free_page_list(struct list_head *list)
> {
> - struct list_head *pos, *next;
> + struct page *page, *next;
>
> - list_for_each_safe(pos, next, list) {
> - struct page *page;
> -
> - page = list_entry(pos, struct page, lru);
> + list_for_each_entry_safe(page, next, list, lru) {

A small improvement, seems better. Ack it.

Please also send kexec mailing list if you have kexec related patchs so
that more people are attracted:

kexec@lists.infradead.org

Acked-by: Baoquan He <bhe@redhat.com>

Thanks
Baoquan


\
 
 \ /
  Last update: 2015-12-11 04:01    [W:0.415 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site