Messages in this thread | | | Date | Fri, 11 Dec 2015 10:38:02 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [PATCH v2 78/71] ncr5380: Add support for HP 53C400A-based cards (C2502) |
| |
On Wed, 9 Dec 2015, Ondrej Zary wrote:
> > > @@ -743,6 +786,7 @@ module_param(ncr_5380, int, 0); > > > module_param(ncr_53c400, int, 0); > > > module_param(ncr_53c400a, int, 0); > > > module_param(dtc_3181e, int, 0); > > > +module_param(hp_53c400a, int, 0); > > > > Any reason you did not add the corresponding __setup option? > > I wonder if __setup is really required. I thought that it should go away > and module parameters used instead.
Yes, after re-reading the header files I see that you are right.
> > > Did you consider re-using the existing ncr_53c400a option (for port & > > irq settings) and adding a new setup option and module param for card > > magic? > > Looks like a good idea.
What I had in mind was an 'ncr_magic' option, to go with 'ncr_irq' and 'ncr_addr'. This is supposed to be a generic driver, after all.
But now that I've seen what that would involve (adding another member to struct override) I've changed my mind.
I think the new board type was the right approach. That is, a combination of your v2 and v3 patches. I'll send my version to you to test.
Thanks.
--
| |