lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers:pci:hotplug Fix all space prohibited before that ,
From
Date
Cool Ill group all whitespace issues in one patch, compile everything and use objdiff to make sure I didnt brake anything and resend.

Thanks, Sasa
{
name: Bogicevic Sasa
phone: +381606006200
}



> On Dec 11, 2015, at 00:24, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Fri, Dec 11, 2015 at 12:07:03AM +0100, sasa bogicevic wrote:
>> I wanted to start with approach one error one folder so I did “space prohibited before ,” in just hotplug folder. I used checkpatch script to see if I nailed it and the output was fine.
>> When I do grep -rl I also get the same result eventhou when I look at the, for example, drivers/pci/hotplug/shpchp_ctrl.c there is no space before comma anywhere. I double checked it. I didn’t do header files unfortunately so that errors are expected I guess.
>>
>> ./scripts/checkpatch.pl --file --terse drivers/pci/hotplug/shpchp_ctrl.c
>> drivers/pci/hotplug/shpchp_ctrl.c:190: WARNING: Block comments use * on subsequent lines
>> drivers/pci/hotplug/shpchp_ctrl.c:264: WARNING: line over 80 characters
>> drivers/pci/hotplug/shpchp_ctrl.c:265: WARNING: line over 80 characters
>> drivers/pci/hotplug/shpchp_ctrl.c:344: ERROR: return is not a function, parentheses are not required
>> drivers/pci/hotplug/shpchp_ctrl.c:359: ERROR: return is not a function, parentheses are not required
>> drivers/pci/hotplug/shpchp_ctrl.c:439: WARNING: Possible unnecessary 'out of memory' message
>> drivers/pci/hotplug/shpchp_ctrl.c:463: WARNING: space prohibited between function name and open parenthesis '('
>> drivers/pci/hotplug/shpchp_ctrl.c:478: WARNING: space prohibited between function name and open parenthesis '('
>> drivers/pci/hotplug/shpchp_ctrl.c:569: WARNING: space prohibited between function name and open parenthesis '('
>> drivers/pci/hotplug/shpchp_ctrl.c:626: WARNING: space prohibited between function name and open parenthesis ‘('
>> total: 2 errors, 8 warnings, 730 lines checked
>>
>> I used objdiff to record and see if I didn’t change anything and I got no output so I guess all is good, don’t know why grep finds “ ,” it is a mystery to me since I am on my working branch, looking at a file and it is not there. Can you also take a look on your side ?
>>
>> I wanted to do one small thing and when I see that it is good and accepted from you then do all warnings and errors one by one.
>
> OK, makes sense. I think you're on the right track, and if you extend
> this patch to all of drivers/pci, I'll apply it.
>
> I see you found the lines that checkpatch didn't complain about.
> Maybe checkpatch doesn't look at things inside quoted strings? That's
> just a guess; I don't use checkpatch regularly.
>
> If you plan to do other things, e.g., removing spaces between the
> function name and open parenthesis, I'd like to have all the "white
> space-only" changes in a single patch.
>
> Bjorn



\
 
 \ /
  Last update: 2015-12-11 01:01    [W:0.053 / U:1.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site