Messages in this thread Patch in this message |  | | From | Namhyung Kim <> | | Subject | [PATCH/RFC 06/16] perf top: Get rid of access to hists->lock in perf_top__record_precise_ip() | | Date | Thu, 10 Dec 2015 16:53:25 +0900 |
| |
It was accessed to release the lock before going to sleep, but now it doesn't go to sleep anymore since warnings will be shown in the display thread.
Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/builtin-top.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index aafcf27c437e..24a5434e8a0b 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -355,20 +355,10 @@ static void perf_top__record_precise_ip(struct perf_top *top, pthread_mutex_unlock(¬es->lock); - if (unlikely(err)) { - /* - * This function is now called with hists->lock held. - * Release it before going to sleep. - */ - pthread_mutex_unlock(&he->hists->lock); - - if (err == -ERANGE) - perf_top__request_warning(top, al, WARN_ERANGE); - else if (err == -ENOMEM) - perf_top__request_warning(top, al, WARN_ENOMEM); - - pthread_mutex_lock(&he->hists->lock); - } + if (err == -ERANGE) + perf_top__request_warning(top, al, WARN_ERANGE); + else if (err == -ENOMEM) + perf_top__request_warning(top, al, WARN_ENOMEM); } static void perf_top__show_details(struct perf_top *top) -- 2.6.2
|  |