lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fixed coding style problems based on checkpatch.pl for goldfish_audio.c
On Thu, Dec 10, 2015 at 12:43:19PM +0530, Sudip Mukherjee wrote:
> On Wed, Dec 09, 2015 at 03:46:02PM -0800, Benjamin Young wrote:
> > From f18a3e5f155f5258d2d19ac6b56bfaafa2ad470b Mon Sep 17 00:00:00 2001
> > From: Benjamin Young <youngcdev@gmail.com>
> > Date: Wed, 9 Dec 2015 13:45:00 -0800
> > Subject: [PATCH] Fixed coding style problems based on checkpatch.pl for
> > goldfish_audio.c
>
> This should not be here.
> You have not given in commit message and you are doing multiple changes
> in this patch. Please split them into separate patch, each patch doing
> only a single type of change.
>
> regards
> sudip

Thanks Sudip I will fix this by creating two new patches.
One for the comparison to null checks and the other for space between operators.

Was there anything else which I could improve on for this commit?

Thanks,
Benjamin


\
 
 \ /
  Last update: 2015-12-10 19:01    [W:1.652 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site