Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH] usb: gadget: make usb_ep_enable return -EBUSY if ep has already enabled | Date | Thu, 10 Dec 2015 11:24:16 -0600 |
| |
Hi,
changbin.du@intel.com writes: > From: "Du, Changbin" <changbin.du@intel.com> > > When usb_ep_enable on a enabled ep, the configuration of the ep probably > has changed. In this scenario, the ep configuration in hw should be > reprogrammed by udc driver. Hence, it is better to return an error to > inform the caller. > > Signed-off-by: Du, Changbin <changbin.du@intel.com> > --- > include/linux/usb/gadget.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h > index d813bd2..89f9fdd 100644 > --- a/include/linux/usb/gadget.h > +++ b/include/linux/usb/gadget.h > @@ -268,7 +268,7 @@ static inline int usb_ep_enable(struct usb_ep *ep) > int ret; > > if (ep->enabled) > - return 0; > + return -EBUSY;
While at that, can you add a WARN_ON() as well ?
if (WARN_ON(ep->enabled)) return -EBUSY;
-- balbi [unhandled content-type:application/pgp-signature]
| |