Messages in this thread | | | Subject | Re: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support | From | Suravee Suthikulanit <> | Date | Thu, 10 Dec 2015 10:11:01 -0600 |
| |
On 12/10/2015 3:14 AM, Marc Zyngier wrote: >> +int __init gicv2m_init(struct fwnode_handle *parent_handle, >> >+ struct irq_domain *parent) >> >+{ >> >+ int ret = gicv2m_of_init(parent_handle, parent); >> >+ >> >+ if (ret) >> >+ ret = gicv2m_acpi_init(parent); >> >+ return ret; > This should really read: > > if (is_of_node(parent_handle)) > return gicv2m_of_init(parent_handle, parent); > > return gicv2m_acpi_init(parent); > > and you can loose the test for NULL in gicv2m_of_init(). >
Right... Your style of returning which is cleaner ;)
I'll update in V7 and send it out shortly.
Thanks, Suravee
| |