lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support
From
Date
On 12/10/2015 3:14 AM, Marc Zyngier wrote:
>> +int __init gicv2m_init(struct fwnode_handle *parent_handle,
>> >+ struct irq_domain *parent)
>> >+{
>> >+ int ret = gicv2m_of_init(parent_handle, parent);
>> >+
>> >+ if (ret)
>> >+ ret = gicv2m_acpi_init(parent);
>> >+ return ret;
> This should really read:
>
> if (is_of_node(parent_handle))
> return gicv2m_of_init(parent_handle, parent);
>
> return gicv2m_acpi_init(parent);
>
> and you can loose the test for NULL in gicv2m_of_init().
>

Right... Your style of returning which is cleaner ;)

I'll update in V7 and send it out shortly.

Thanks,
Suravee


\
 
 \ /
  Last update: 2015-12-10 17:41    [W:0.049 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site