lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 06/10] ARM: realview: enable multiplatform
Date
On Thursday 10 December 2015 11:04:31 Linus Walleij wrote:
> On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > All obstacles are out of the way by now, so we can finally move realview
> > to multiplatform.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Russell King <linux@arm.linux.org.uk>
> (...)
>
> > -obj-y := core.o
> > obj-$(CONFIG_REALVIEW_DT) += realview-dt.o
> > +ifdef $(CONFIG_ATAGS)
> > +obj-y := core.o
> > obj-$(CONFIG_MACH_REALVIEW_EB) += realview_eb.o
> > obj-$(CONFIG_MACH_REALVIEW_PB11MP) += realview_pb11mp.o
> > obj-$(CONFIG_MACH_REALVIEW_PB1176) += realview_pb1176.o
> > obj-$(CONFIG_MACH_REALVIEW_PBA8) += realview_pba8.o
> > obj-$(CONFIG_MACH_REALVIEW_PBX) += realview_pbx.o
> > +endif
>
> This isn't working. Even if CONFIG_ATAGS is set, none of the files
> inside this ifdef $(CONFIG_ATAGS) are compiled. Does Kconfig
> only support if and not ifdef?
>

Oh, it's a silly typo:

it should be "ifdef CONFIG_ATAGS", not "ifdef $(CONFIG_ATAGS)"

Sorry about that.

Arnd


\
 
 \ /
  Last update: 2015-12-10 12:41    [W:0.293 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site