lkml.org 
[lkml]   [2015]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] clk: qcom: common: check for failure
Date
We were not checking the return from devm_add_action() which can fail.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/clk/qcom/common.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
index c112eba..3541a9a 100644
--- a/drivers/clk/qcom/common.c
+++ b/drivers/clk/qcom/common.c
@@ -213,7 +213,10 @@ int qcom_cc_really_probe(struct platform_device *pdev,
if (ret)
return ret;

- devm_add_action(dev, qcom_cc_del_clk_provider, pdev->dev.of_node);
+ ret = devm_add_action(dev, qcom_cc_del_clk_provider,
+ pdev->dev.of_node);
+ if (ret)
+ return ret;

reset = &cc->reset;
reset->rcdev.of_node = dev->of_node;
@@ -236,8 +239,12 @@ int qcom_cc_really_probe(struct platform_device *pdev,
return ret;
}

- devm_add_action(dev, qcom_cc_gdsc_unregister, dev);
-
+ ret = devm_add_action(dev, qcom_cc_gdsc_unregister, dev);
+ if (ret) {
+ if (desc->gdscs && desc->num_gdscs)
+ gdsc_unregister(dev);
+ return ret;
+ }

return 0;
}
--
1.9.1


\
 
 \ /
  Last update: 2015-12-01 10:21    [W:0.068 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site