lkml.org 
[lkml]   [2015]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] regulator: Add coupled regulator
Hi Javier,

On Mon, Nov 30, 2015 at 04:06:14PM -0300, Javier Martinez Canillas wrote:
> Hello Maxime,
>
> On Mon, Nov 30, 2015 at 12:29 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>
> [snip]
>
> >
> > +config REGULATOR_COUPLED_VOLTAGE
>
> Shouldn't this depend on OF?
>
> > + tristate "Coupled voltage regulator support"
>
> the Kconfig symbol is tristate so the driver can be built as a module...
>
> > +
> > +static struct of_device_id coupled_regulator_of_match[] = {
> > + { .compatible = "coupled-voltage-regulator" },
> > + { /* Sentinel */ },
> > +};
> > +
>
> ...but the driver is missing a MODULE_DEVICE_TABLE(of, ...) so module
> autoloading won't work.

You're right, it will be in the v2.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-12-01 22:41    [W:0.064 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site