Messages in this thread | | | Subject | Re: [PATCH] Input: atmel_mxt_ts - add generic platform data for Chromebooks | From | Javier Martinez Canillas <> | Date | Tue, 1 Dec 2015 18:25:15 -0300 |
| |
Hello Dmitry,
On 12/01/2015 06:21 PM, Dmitry Torokhov wrote:
[snip]
>>> >>> +static unsigned int chromebook_tp_buttons[] = { >> >> Maybe naming it chromebook_t19_buttons instead to make it clear that the >> mapping is specific to the T19 object or at least document that assumption? > > The idea was to document that the mapping is applied to the touchpad > and not any other Atmel device that might have T19 object in it, similar > to samus_touchpad_buttons[] array. >
You are right, the naming makes sense then indeed.
Thanks a lot for the explanation.
>> >> Although is mentioned in the commit message so I don't have a strong >> preference and the patch looks good to me: >> >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Thank you for the review. >
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |