Messages in this thread | | | Date | Tue, 01 Dec 2015 15:35:17 -0500 (EST) | Subject | Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation | From | David Miller <> |
| |
From: Michal Hocko <mhocko@kernel.org> Date: Mon, 30 Nov 2015 14:21:29 +0100
> On Sat 28-11-15 15:51:13, Pavel Machek wrote: >> >> atl1c driver is doing order-4 allocation with GFP_ATOMIC >> priority. That often breaks networking after resume. Switch to >> GFP_KERNEL. Still not ideal, but should be significantly better. > > It is not clear why GFP_KERNEL can replace GFP_ATOMIC safely neither > from the changelog nor from the patch context.
Earlier in the function we do a GFP_KERNEL kmalloc so:
¯\_(ツ)_/¯
It should be fine.
| |