Messages in this thread | | | Date | Tue, 01 Dec 2015 15:32:39 -0500 (EST) | Subject | Re: [PATCH] net: add support for netdev notifier error injection | From | David Miller <> |
| |
From: Nikolay Aleksandrov <razor@blackwall.org> Date: Sat, 28 Nov 2015 13:45:28 +0100
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> > > This module allows to insert errors in some of netdevice's notifier > events. All network drivers use these notifiers to signal various events > and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU > afterwards. Until recently I had to run failure tests by injecting > a custom module, but now this infrastructure makes it trivial to test > these failure paths. Some of the recent bugs I fixed were found using > this module. > Here's an example: > $ cd /sys/kernel/debug/notifier-error-inject/netdev > $ echo -22 > actions/NETDEV_CHANGEMTU/error > $ ip link set eth0 mtu 1024 > RTNETLINK answers: Invalid argument > > CC: Akinobu Mita <akinobu.mita@gmail.com> > CC: "David S. Miller" <davem@davemloft.net> > CC: netdev <netdev@vger.kernel.org> > Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
This looks fine, applied to net-next, thanks!
| |