lkml.org 
[lkml]   [2015]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] hv_netvsc: rework link status change handling
From
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Fri, 27 Nov 2015 11:39:55 +0100

> There are several issues in hv_netvsc driver with regards to link status
> change handling:
> - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing
> '/etc/init.d/network restart' and this is inappropriate and broken for
> many reasons.
> - link_watch infrastructure only sends one notification per second and
> in case of e.g. paired disconnect/connect events we get only one
> notification with last status. This makes it impossible to handle such
> situations in userspace.
>
> Redo link status changes handling in the following way:
> - Create a list of reconfig events in network device context.
> - On a reconfig event add it to the list of events and schedule
> netvsc_link_change().
> - In netvsc_link_change() ensure 2-second delay between link status
> changes.
> - Handle RNDIS_STATUS_NETWORK_CHANGE as a paired disconnect/connect event.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Applied, thank you.


\
 
 \ /
  Last update: 2015-12-01 21:21    [W:0.032 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site