Messages in this thread | | | Date | Tue, 1 Dec 2015 10:39:40 -0700 | From | Jason Gunthorpe <> | Subject | Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter |
| |
On Tue, Dec 01, 2015 at 12:50:28PM +0100, Wilck, Martin wrote:
> The patch introduces one user-visible change, because now the ACPI and > PnP drivers are registered even with "force=1". This causes my TPM to be > show up twice in sysfs:
Registering all the drivers is deliberate, IMHO, force should not be used if the driver binds normally.
However, getting two is a bug, and it is because tpm_tis is not doing resource management.
I'll add another patch to fix that..
Also, I'll change the order of the driver registers so that the platform driver goes first, that way if force is used the platform driver will bind and still auto probe irqs and then the other drivers will bounce off the claimed resource.
Jason
| |