lkml.org 
[lkml]   [2015]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] livepatch: fix race between enabled_store() and klp_unregister_patch()
From
Date
On 12/01/2015, 03:13 PM, Petr Mladek wrote:
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -612,7 +612,19 @@ static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr,
>
> patch = container_of(kobj, struct klp_patch, kobj);
>
> - mutex_lock(&klp_mutex);
> + /*
> + * Avoid a deadlock with kobject_put(&patch->kobj) that is
> + * called under klp_mutex. Bail out when the patch is not
> + * longer registered.
> + */
> + if (!mutex_trylock(&klp_mutex)) {

This introduces false positives.
Deleting/enabling/disabling/other_op_under_klp_mutex of an unrelated
patch may now cause enabled_store to fail. Hence I don't like this
approach at all.

thanks,
--
js
suse labs


\
 
 \ /
  Last update: 2015-12-01 15:41    [W:0.060 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site