lkml.org 
[lkml]   [2015]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
Date
On Mon, Nov 30, 2015, at 22:38, Eric W. Biederman wrote:
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> ---
> net/bridge/br_stp_if.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
> index 5396ff08af32..742fa89528ab 100644
> --- a/net/bridge/br_stp_if.c
> +++ b/net/bridge/br_stp_if.c
> @@ -142,7 +142,9 @@ static void br_stp_start(struct net_bridge *br)
> char *envp[] = { NULL };
> struct net_bridge_port *p;
>
> - r = call_usermodehelper(BR_STP_PROG, argv, envp, UMH_WAIT_PROC);
> + r = -ENOENT;
> + if (dev_net(br->dev) == &init_net)

net_eq ?

> + r = call_usermodehelper(BR_STP_PROG, argv, envp,
> UMH_WAIT_PROC);
>
> spin_lock_bh(&br->lock);
>

Otherwise, ack, so far.

As our /sys interfaces directories are tagged by the net namespace it
would actually make sense to run bridge-stp automatically in another
name space.

Bye,
Hannes


\
 
 \ /
  Last update: 2015-12-01 15:21    [W:0.075 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site