Messages in this thread | | | Date | Tue, 1 Dec 2015 12:16:51 +0000 | From | Graeme Gregory <> | Subject | Re: [PATCH 2/3] ACPI: scan add call to probe amba devices |
| |
On Tue, Dec 01, 2015 at 03:16:53AM +0100, Rafael J. Wysocki wrote: > On Wednesday, September 30, 2015 11:38:49 AM Graeme Gregory wrote: > > Call the amba device creation function in the default enumeration path, > > this is the same location platform devices are probed. > > First, I'm sorry for the glacially slow response here. > > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > > Cc: Len Brown <lenb@kernel.org> > > Cc: Russell King <linux@arm.linux.org.uk> > > Signed-off-by: Graeme Gregory <graeme.gregory@linaro.org> > > --- > > drivers/acpi/scan.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > index f834b8c..aa3184e 100644 > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -1633,8 +1633,10 @@ static void acpi_default_enumeration(struct acpi_device *device) > > acpi_dev_get_resources(device, &resource_list, acpi_check_spi_i2c_slave, > > &is_spi_i2c_slave); > > acpi_dev_free_resource_list(&resource_list); > > - if (!is_spi_i2c_slave) > > + if (!is_spi_i2c_slave) { > > + acpi_create_amba_device(device); > > Do you really have to add this here? > > It would be much cleaner to use a new scan handler instead. >
I can certainly look into doing that, I cannot from a quick scan see any reason not too. I just didn't think of it.
Graeme
| |