Messages in this thread | | | Subject | Re: [PATCH net-next] sfc: use ALIGN macro for aligning frame sizes | From | Bert Kenward <> | Date | Tue, 1 Dec 2015 11:58:40 +0000 |
| |
On 30/11/15 22:12, Jarod Wilson wrote: > Don't open-code it. > > CC: Solarflare linux maintainers <linux-net-drivers@solarflare.com> > CC: Shradha Shah <sshah@solarflare.com> > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson <jarod@redhat.com>
Acked-by: Bert Kenward <bkenward@solarflare.com>
> --- > drivers/net/ethernet/sfc/net_driver.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/net_driver.h b/drivers/net/ethernet/sfc/net_driver.h > index a8ddd12..746d591 100644 > --- a/drivers/net/ethernet/sfc/net_driver.h > +++ b/drivers/net/ethernet/sfc/net_driver.h > @@ -1502,8 +1502,9 @@ static inline struct efx_rx_buffer *efx_rx_buffer(struct efx_rx_queue *rx_queue, > * same cycle, the XMAC can miss the IPG altogether. We work around > * this by adding a further 16 bytes. > */ > +#define EFX_FRAME_PAD 16 > #define EFX_MAX_FRAME_LEN(mtu) \ > - ((((mtu) + ETH_HLEN + VLAN_HLEN + 4/* FCS */ + 7) & ~7) + 16) > + (ALIGN(((mtu) + ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN + EFX_FRAME_PAD), 8)) > > static inline bool efx_xmit_with_hwtstamp(struct sk_buff *skb) > { >
| |