Messages in this thread | | | Date | Tue, 1 Dec 2015 11:30:25 +0100 | Subject | Re: [PATCH 10/10] xattr handlers: Simplify list operation | From | Andreas Grünbacher <> |
| |
2015-12-01 10:53 GMT+01:00 James Morris <jmorris@namei.org>: > On Mon, 30 Nov 2015, Andreas Gruenbacher wrote: > >> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c >> index 906022d..61dd93f 100644 >> --- a/fs/ocfs2/xattr.c >> +++ b/fs/ocfs2/xattr.c >> @@ -895,6 +895,8 @@ static int ocfs2_xattr_list_entry(char *buffer, size_t size, >> >> *result += total_len; >> >> + /* FIXME: Not checking the ->list operation here ... */ >> + > > What does this mean?
ocfs2 defines list xattr handler operations for "user.*" and "trusted.*" xattrs but never bothers calling them. Should be fixed separately.
Thanks, Andreas
| |