Messages in this thread | | | Subject | Re: [PATCH V2 2/3] scsi: fix compiler warning for sg | From | Sinan Kaya <> | Date | Mon, 9 Nov 2015 23:51:35 -0500 |
| |
On 11/9/2015 10:26 PM, Timur Tabi wrote: > Sinan Kaya wrote: >> >> I created this patch back in March with an older version of the compiler >> and older kernel (3.19). I'm no longer able to reproduce this with this >> compiler and linux-next. >> >> Thread model: posix >> gcc version 4.8.3 20140401 (prerelease) (crosstool-NG >> linaro-1.13.1-4.8-2014.04 - Linaro GCC 4.8-2014.04) >> >> I'll drop this patch. > > Are you sure the compiler handles the old macro correctly? Maybe it's > just quiescing the error message, but it's still broken? >
The code says it is using these macros for small integers only which can't overflow. I was trying to get rid of compiler warning and it seems to have disappeared.
-- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |