Messages in this thread | | | Subject | Re: [PATCH 1/8] block/genhd.c: Add error handling | From | Jens Axboe <> | Date | Mon, 9 Nov 2015 20:40:58 -0700 |
| |
On 11/09/2015 08:33 PM, Al Viro wrote: > On Fri, Nov 06, 2015 at 05:52:08PM +0530, Vishnu Pratap Singh wrote: > > Have you even tried to trigger the failure exits you've added? The > more you've successfully set up, the _less_ your cleanup code ends > up undoing; that simply can't be right. > > That aside, as soon as we'd done register_disk(), the damn thing is > available for open(), so bailing out is _really_ not something for > faint-hearted - it's essentially equivalent to removal of device under > somebody who'd opened it and might've started IO, etc. Going there > simply because some sysfs shite didn't get created doesn't look sane > as far as I'm concerned... > > Especially since these failure exits are not going to be tested on > a regular basis, so the amount of bitrot will be pretty high ;-/
I'd greatly prefer it we just leave it alone. Much better to have a disk that does actually work and with some sysfs spew in the logs, than bail out for fairly vague reasons.
The road to hell is paved with good intentions. It's a noble thought to want to clean this up, but I think it does more harm than good.
-- Jens Axboe
| |