Messages in this thread | | | Date | Mon, 9 Nov 2015 16:16:16 +0200 | Subject | Re: [PATCH] gpio: 74xx: fix a possible NULL dereference | From | Andy Shevchenko <> |
| |
On Mon, Nov 9, 2015 at 2:21 AM, Alexandre Courbot <gnurou@gmail.com> wrote: > On Fri, Nov 6, 2015 at 12:55 AM, LABBE Corentin > <clabbe.montjoie@gmail.com> wrote: >> of_match_device could return NULL, and so cause a NULL pointer >> dereference later at line 132: >> priv->flags = (uintptr_t) of_id->data; >> >> Reported-by: coverity (CID 1324141) >> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> >> --- >> drivers/gpio/gpio-74xx-mmio.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c >> index 6ed7c0f..4a7be0f 100644 >> --- a/drivers/gpio/gpio-74xx-mmio.c >> +++ b/drivers/gpio/gpio-74xx-mmio.c >> @@ -120,6 +120,9 @@ static int mmio_74xx_gpio_probe(struct platform_device *pdev) >> void __iomem *dat; >> int err; >> >> + if (!of_id) >> + return -ENODEV; >> + > > Nit: in that case, could you also move the assignment of of_id to its > own line right above these added lines? It would keep things in the > same place
I think it's more that just a nit. +1 to move assignment.
-- With Best Regards, Andy Shevchenko
| |