Messages in this thread | | | Date | Mon, 9 Nov 2015 15:57:28 +0200 | Subject | Re: [PATCH V2 1/6] dmaengine: tegra-apb: Correct runtime-pm usage | From | Andy Shevchenko <> |
| |
On Mon, Nov 9, 2015 at 3:23 PM, Jon Hunter <jonathanh@nvidia.com> wrote: > The tegra-apb DMA driver enables runtime-pm but never calls > pm_runtime_get/put and hence the runtime-pm callbacks are never invoked. > The driver manages the clocks by directly calling clk_prepare_enable() > and clk_unprepare_disable(). > > Fix this by replacing the clk_prepare_enable() and clk_disable_unprepare() > with pm_runtime_get_sync() and pm_runtime_put(), respectively. Note that > the consequence of this is that if runtime-pm is disabled, then the clocks > will remain on the entire time the driver is loaded. However, if > runtime-pm is disabled, then power is not most likely not a concern.
Nitpick
> @@ -1539,11 +1534,10 @@ static int tegra_dma_runtime_resume(struct device *dev) > static int tegra_dma_pm_suspend(struct device *dev) > { > struct tegra_dma *tdma = dev_get_drvdata(dev); > - int i; > - int ret; > + int i, ret;
> static int tegra_dma_pm_resume(struct device *dev) > { > struct tegra_dma *tdma = dev_get_drvdata(dev); > - int i; > - int ret; > + int i, ret;
Do you really need that?
-- With Best Regards, Andy Shevchenko
| |