Messages in this thread | | | Date | Mon, 9 Nov 2015 14:27:58 +0100 | Subject | Re: [PATCH 21/26] Input: synaptics-rmi4: Add support for F12 | From | Linus Walleij <> |
| |
On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan <aduggan@synaptics.com> wrote:
> Function 12 implements 2D touch position sensor for newer Synaptics touch > devices. It replaces F11 and no device will contain both functions. > > Signed-off-by: Andrew Duggan <aduggan@synaptics.com> (...) > +config RMI4_F12 > + bool "RMI4 Function 12 (2D pointing)" > + depends on RMI4_2D_SENSOR
So this properly depends on RMI4_2D_SENSOR (you missed this for F11 IIUC).
But I think the approach to have it select RMI4_2D_SENSOR (which is to be hidden) is a better approach.
This stand-alone F12 patch is nice though, that is how all patches should look: add a function.
Yours, Linus Walleij
| |