Messages in this thread | | | Subject | Re: [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver | From | Sinan Kaya <> | Date | Sun, 8 Nov 2015 21:17:20 -0500 |
| |
On 11/8/2015 12:08 AM, Timur Tabi wrote:
On 11/8/2015 12:08 AM, Timur Tabi wrote: > Sinan Kaya wrote: >> + val = val & ~(MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS); >> + val = val | (mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS); >> + val = val & ~(MAX_BUS_REQ_LEN_MASK); >> + val = val | (mgmtdev->max_read_request); > > val &= ~MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS; > val |= mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS; > val &= ~MAX_BUS_REQ_LEN_MASK; > val |= mgmtdev->max_read_request; > >> +static const struct of_device_id hidma_mgmt_match[] = { >> + { .compatible = "qcom,hidma-mgmt", }, >> + { .compatible = "qcom,hidma-mgmt-1.0", }, >> + { .compatible = "qcom,hidma-mgmt-1.1", }, >> + {}, >> +}; > > I thought Rob said that he did NOT want to use version numbers in > compatible strings. And what's the difference between these three > versions anyway? >
This was already discussed here.
https://lkml.org/lkml/2015/11/2/689
The agreement was to use
compatible = "qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt";
I'll be adding code for v1.1 specifically in the future.
-- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |