Messages in this thread | | | From | Alexandre Courbot <> | Date | Mon, 9 Nov 2015 08:53:04 +0900 | Subject | Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables |
| |
On Wed, Nov 4, 2015 at 9:30 PM, William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > To prevent confusion and to match existing coding style used in other > gpio drivers symbol names within the 104-idio-16 gpio driver should be > lowercase.
... and for the same styling reasons "GPIO" should be spelled in uppercase in your commit message. ;)
Apart from that this patch seems harmless and the repositioning of some constant declarations is also welcome.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
| |