lkml.org 
[lkml]   [2015]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/12] staging: rtl8188eu: return value and argument types changed in _rtl88e_write_fw function
From
On Sun, Nov 8, 2015 at 1:26 PM, Ivan Safonov <insafonov@gmail.com> wrote:
> On 11/08/2015 05:11 PM, Andy Shevchenko wrote:
>>
>> On Sun, Nov 8, 2015 at 8:37 AM, Ivan Safonov <insafonov@gmail.com> wrote:
>>>
>>> Ideally the function should not change the variables outside of its body.

>>> -static void _rtl88e_fill_dummy(u8 *pfwbuf, u32 *pfwlen)
>>> +static u32 _rtl88e_fill_dummy(u8 *pfwbuf, u32 pfwlen)
>>> {
>>> u32 i;
>>>
>>> - for (i = *pfwlen; i < roundup(*pfwlen, 4); i++)
>>> + for (i = pfwlen; i < roundup(pfwlen, 4); i++)
>>> pfwbuf[i] = 0;
>>
>> memset() ?
>>
>>> - *pfwlen = i;
>>> + return i;
>>> }
>>>
>>> static void _rtl88e_fw_page_write(struct adapter *adapt,
>>> @@ -103,7 +103,7 @@ static void _rtl88e_write_fw(struct adapter *adapt,
>>> u8 *buffer, u32 size)
>>> u32 page_no, remain;
>>> u32 page, offset;
>>>
>>> - _rtl88e_fill_dummy(buf_ptr, &size);
>>> + size = _rtl88e_fill_dummy(buf_ptr, size);


> memset applied in another patch. Here only replacement of the function type.

Since it's used only once it would be nice to replace it by plain
memset() in one patch.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2015-11-08 22:01    [W:0.048 / U:2.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site